Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perpendicular diffusivity in NODDI priors #872

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

gagnonanthony
Copy link
Contributor

@gagnonanthony gagnonanthony commented Dec 19, 2023

Quick description

Useful when computing priors for COMMIT stick-zeppelin-ball model. Added the RD map as input and used the same 1 fiber voxels as the parallel diffusivity (AD).

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore self-requested a review December 19, 2023 21:28
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@gagnonanthony gagnonanthony changed the title Add perpendicular diffusivity in NODDI priors [WIP] Add perpendicular diffusivity in NODDI priors Dec 20, 2023
@arnaudbore
Copy link
Contributor

Build passed ! Good Job 🍻 !

@arnaudbore arnaudbore added the WIP Work In Progress label Jan 11, 2024
@gagnonanthony gagnonanthony changed the title [WIP] Add perpendicular diffusivity in NODDI priors Add perpendicular diffusivity in NODDI priors Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dcf990) 65.77% compared to head (6f0d51c) 65.93%.
Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
+ Coverage   65.77%   65.93%   +0.16%     
==========================================
  Files         384      384              
  Lines       21341    21340       -1     
  Branches     3494     3492       -2     
==========================================
+ Hits        14037    14071      +34     
+ Misses       5700     5664      -36     
- Partials     1604     1605       +1     
Components Coverage Δ
Scripts ∅ <ø> (∅)
Library ∅ <ø> (∅)

@arnaudbore arnaudbore removed the WIP Work In Progress label Feb 14, 2024
Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@arnaudbore arnaudbore merged commit a4f5d4f into scilus:master Feb 14, 2024
1 check passed
@gagnonanthony gagnonanthony deleted the perpdiff branch February 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants